aboutsummaryrefslogtreecommitdiff
path: root/tests/Jellyfin.MediaEncoding.Tests/Subtitles
AgeCommit message (Collapse)Author
5 daysFix subtitle encoding for local files (#17281)Tim Eisele
* Fix subtitle encoding * Add short-circuit * Use IsTextFormat * Update MediaBrowser.MediaEncoding/Subtitles/SubtitleEncoder.cs Co-authored-by: Bond-009 <bond.009@outlook.com> --------- Co-authored-by: Bond-009 <bond.009@outlook.com>
11 daysFix race condition in concurrent subtitle conversionPiotr Niełacny
SubtitleEncoder.ConvertSubtitles parsed subtitles with libse's static Subtitle.Parse, which iterates a statically cached list of shared SubtitleFormat instances. Format parsers keep mutable per-parse state on the instance, so concurrent subtitle requests corrupted each other's output (cues mixed across streams and languages, truncated files) or failed with NullReferenceException when format detection broke down and Subtitle.Parse returned null. Parse through the injected ISubtitleParser instead. SubtitleEditParser instantiates a fresh format parser per call, so requests no longer share state. Its Parse method now returns the libse Subtitle directly (the SubtitleTrackInfo flattening was unused since the SubtitleEdit writer rework) so the writers keep full fidelity such as ASS styling.
2026-05-30Write subtitles using SubtitleEditBond_009
We've been using SubtitleEdit to parse since 2021 https://github.com/jellyfin/jellyfin/pull/4984 I think it's time we start using it to write too
2026-04-15fix: retain subtitles spanning HLS segment boundaries (#16594)Hilmar Gústafsson
fix: retain subtitles spanning HLS segment boundaries
2023-09-18Fix xUnit1030: Do not call ConfigureAwait in test methodBond_009
2023-09-11Removed nesting levels through block-scoped `using` statement (#10025)Lehonti Ramos
Co-authored-by: John Doe <john@doe> Co-authored-by: Lehonti Ramos <lehonti@ramos>
2023-01-11Fix all warnings in MediaBrowser.MediaEncoding (#9073)Bond-009
2022-09-28Remove redundant using directivesHannes Braun
2022-09-09Fix build errors from new warningsCody Robibero
2022-08-01Backport pull request #8087 from jellyfin/release-10.8.zJoshua Boniface
feat: make subtitleeditparser generic Authored-by: Claus Vium <cvium@users.noreply.github.com> Merged-by: Bond-009 <bond.009@outlook.com> Original-merge: 7323ccfc232d31797af3ceb8bad93cae1ea0898d
2021-10-03Fix warning: Using directive is not required by the code and can be safely ↵KonH
removed (#2149)
2021-09-25Merge branch 'master' into theorydataBond-009
2021-09-22Add regression test for #5323Bond_009
2021-09-18Add regression test for issue #5168Bond_009
2021-09-18Fix SubtitleEncoder and add regression testsBond_009
2021-09-11Use TheoryData instead of MemberData and ClassDataianjazz246
2021-03-01Remove tests that are upstreamedBond_009
libse (the SSA parser we use) has these same tests now
2021-02-09Comment out broken testsBond_009
2021-02-09Fix tests on windowsBond_009
2021-02-09Log subtitle errorsBond_009
2021-02-09Use SubtitleEdit to parse subtitlesBond_009
2021-01-08Merge pull request #4877 from jellyfin/assBond-009
2020-12-28Add tests for srt parserBond_009
2020-12-28Add tests for ass parserBond_009