aboutsummaryrefslogtreecommitdiff
path: root/Emby.Server.Implementations
AgeCommit message (Collapse)Author
7 hoursTranslated using Weblate (Icelandic)HEADmasterShed Shedson
Translation: Jellyfin/Jellyfin Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/is/
9 hoursMerge pull request #17399 from Shadowghost/fix-extra-yearCody Robibero
Fix incorrect year on local trailers
13 hoursMerge pull request #17395 from paoloantinori/fix/userdata-null-user-nre-masterCody Robibero
Avoid NRE when sorting by user-dependent keys without a user
14 hoursTranslated using Weblate (Faroese)krvi
Translation: Jellyfin/Jellyfin Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/fo/
14 hoursTranslated using Weblate (Hindi)Suyash Mittal
Translation: Jellyfin/Jellyfin Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/hi/
15 hoursRemove added comments (#17395 review)Paolo Antinori
25 hoursMerge pull request #17411 from mbastian77/perf/session-manager-tolistCody Robibero
perf: avoid unnecessary list allocation in CheckForIdlePlayback
3 daysAvoid unnecessary list allocation in CheckForIdlePlaybackmbastian77
4 daysPrefer null checks over HasValue everywhereShadowghost
4 daysfix: avoid NRE when sorting by user-dependent keys without a userPaolo Antinori
A query sorted by a user-dependent key (PlayCount, IsFavoriteOrLiked, DatePlayed, IsPlayed, IsUnplayed) but carrying no User caused a NullReferenceException inside UserDataManager.GetUserData, surfacing as "Failed to compare two elements in the array" (InvalidOperationException wrapping the NRE from the LINQ sort) and 500-ing the /Items request. Root cause: LibraryManager.GetComparer assigned comparer.User = user without a null guard, so PlayCountComparer.GetValue called UserDataManager.GetUserData(null, item), dereferencing user.Id. Two-part fix: - LibraryManager.GetComparer: when user is null and the sort key requires a user (IUserBaseItemComparer), substitute the SortName comparer so the result stays deterministic instead of 500-ing. SortName is the project's canonical tiebreaker (ItemsController injects it for album-by-artist). - UserDataManager.GetUserData: ArgumentNullException.ThrowIfNull(user) as defense in depth (matches the existing guards on the SaveUserData overloads in the same file). On master this overload was rewritten to use ResolveUserDataRow, so the NRE dereferences user.Id rather than user.InternalId as on the release branch — same bug, different line. Also fixes DateLastMediaAddedComparer being statically mis-tagged as IUserBaseItemComparer: its GetDate is static and never reads User, so it does not need one. Without this, the SortName fallback above would wrongly engage for DateLastContentAdded on anonymous queries (returning SortName order instead of date order). Re-tagged to IBaseItemComparer and dropped the unused User/UserManager/UserDataManager properties. Tests: - UserDataManagerTests.GetUserData_NullUser_ThrowsArgumentNullException: reproduces the crash (NRE -> now ArgumentNullException). Added to master's existing UserDataManagerTests. - LibraryManagerSortTests.Sort_UserDependentKey_NullUser_FallsBackToSortNameWithoutThrowing: Sort with a user-dependent key + null user no longer throws and returns items ordered by the SortName fallback (direction preserved). - LibraryManagerSortTests.Sort_DateLastContentAdded_NullUser_OrdersByDateNotSortName: guards that DateLastContentAdded still sorts by date with no user (fixture chosen so date-desc and SortName-desc disagree, so a revert is caught). Full Jellyfin.Server.Implementations.Tests suite: 642 passed, 0 failed. Fixes #17393
4 daysMerge pull request #16980 from ↵Cody Robibero
TheMelmacian/feature/library_specific_language_filter_values Improve language filters to only fetch language codes that match the requested items/libraries (follow up to #9787)
4 daysMerge pull request #17369 from Shadowghost/harden-startup-wizardCody Robibero
Prevent unauthenticated re-run of the startup wizard on misconfiguration
4 daysFix incorrect year on local trailersShadowghost
4 daysMerge pull request #17160 from 854562/truncate-language-stringsCody Robibero
Truncate ISO-639-2 language display names at first delimiter
4 daysTranslated using Weblate (Latvian)aivarsse
Translation: Jellyfin/Jellyfin Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/lv/
5 daysMerge remote-tracking branch 'upstream/master' into ↵Shadowghost
security-path-traversal-fixes # Conflicts: # Jellyfin.Api/Controllers/HlsSegmentController.cs # Jellyfin.Api/Controllers/PluginsController.cs
5 daysTranslated using Weblate (Icelandic)Shed Shedson
Translation: Jellyfin/Jellyfin Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/is/
5 daysMerge pull request #17320 from TaterTechStudios/fix/item-correct-selectorCody Robibero
Fix: Fetch the correct row matching the most up to date file
5 daysMerge pull request #17254 from sjakub/attribute_aliasesCody Robibero
Add additional attribute aliases and improve attribute detection
5 daysExtract truncation logic to helper and add tests854562
6 daysAdd TVDB provider ID support for movies (#17255)theguymadmax
Add TVDB provider ID support for movies
6 daysMerge pull request #17252 from theguymadmax/fix-alubms-and-artistsBond-009
Fix artists being displayed with albums
6 daysTranslated using Weblate (Faroese)krvi
Translation: Jellyfin/Jellyfin Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/fo/
6 daysTranslated using Weblate (Croatian)Milo Ivir
Translation: Jellyfin/Jellyfin Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/hr/
6 daysMerge pull request #17365 from Shadowghost/fix-resume-perfBond-009
Fix Resume query performance
7 daysTranslated using Weblate (Faroese)krvi
Translation: Jellyfin/Jellyfin Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/fo/
7 daysTranslated using Weblate (Faroese)krvi
Translation: Jellyfin/Jellyfin Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/fo/
8 daysTranslated using Weblate (Chinese (Traditional Han script))CHO-HSUN-TE
Translation: Jellyfin/Jellyfin Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/zh_Hant/
8 daysMerge pull request #17288 from nyanmisaka/ffmpeg-log-utf8Bond-009
Fix potential garbled text in FFmpeg logs on Windows
8 daysMerge pull request #17327 from ↵Bond-009
Shadowghost/remove-playbackpositionticks-mediasourceinfo Remove PlaybackPositionTicks from MediaSourceInfo
8 daysMerge pull request #17280 from Shadowghost/remove-image-override-hackBond-009
Remove episode image override hack
8 daysPrevent unauthenticated re-run of the startup wizard on misconfigurationShadowghost
8 daysSanitize media attachment and lyric paths against traversalShadowghost
9 daysMerge pull request #17338 from mbastian77/docs/deviceid-xml-docsBond-009
9 daysTranslated using Weblate (Spanish (Latin America))Fabián Sanhueza
Translation: Jellyfin/Jellyfin Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/es_419/
10 daysFix user data batch query perfShadowghost
10 daysMove GetUserDataBatch to use ResolveUserDataRow when item.UserData isn't ↵Jordan Rushing
preloaded
11 daysAdd XML docs to DeviceId and remove CS1591 suppressionmbastian77
11 daysLimit similar items to user accessible librariesShadowghost
12 daysremove PlaybackPositionTicks from MediaSourceInfoShadowghost
12 daysFix: Fetch the correct row matching the most up to date fileJordan Rushing
12 daysMerge pull request #17273 from theguymadmax/ratigs-numerical-scoreBond-009
13 daysTranslated using Weblate (Hebrew)DrummingBird1
Translation: Jellyfin/Jellyfin Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/he/
13 daysApply review feedbacktheguymadmax
2026-07-10Fix potential garbled text in FFmpeg logs on Windowsnyanmisaka
Explicitly set StandardErrorEncoding and StandardOutputEncoding to Encoding.UTF8 when invoking the FFmpeg subprocess. This prevents log encoding issues and character corruption on Windows environments that default to non-UTF8 ANSI code pages. This fixes garbled metadata and font names in the FFmpeg logs. Signed-off-by: nyanmisaka <nst799610810@gmail.com>
2026-07-09Cleanup PreferEpisodeParentPoster)Shadowghost
2026-07-09Remove episode image override hackShadowghost
2026-07-08Check numeric rating value after splitting country codetheguymadmax
2026-07-08Fix Greece parental ratingstheguymadmax
2026-07-08Replaced string.Empty with ReadOnlySpan<char>.EmptyJakub Schmidtke
generated by cgit v1.2.3 (git 2.46.0) at 2026-07-26 02:02:37 +0000