aboutsummaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorShadowghost <Ghost_of_Stone@web.de>2026-10-24 11:33:46 +0200
committerShadowghost <Ghost_of_Stone@web.de>2026-10-24 11:33:46 +0200
commit6561d58ad512bdc4dfd6dacf55a5b03b2a143623 (patch)
tree6d69ad73d1202fb8c70a876caf47bf25a3b600bf /tests
parent0c817274b76aebcc07b4c4de068dd6d06eb45d9c (diff)
Fix review comments
Diffstat (limited to 'tests')
-rw-r--r--tests/Jellyfin.Server.Implementations.Tests/Library/LibraryManager/LibraryRootIgnoreTests.cs93
-rw-r--r--tests/Jellyfin.Server.Integration.Tests/DotIgnoreLibraryRootTests.cs55
2 files changed, 148 insertions, 0 deletions
diff --git a/tests/Jellyfin.Server.Implementations.Tests/Library/LibraryManager/LibraryRootIgnoreTests.cs b/tests/Jellyfin.Server.Implementations.Tests/Library/LibraryManager/LibraryRootIgnoreTests.cs
new file mode 100644
index 0000000000..f37aadbe8d
--- /dev/null
+++ b/tests/Jellyfin.Server.Implementations.Tests/Library/LibraryManager/LibraryRootIgnoreTests.cs
@@ -0,0 +1,93 @@
+using System;
+using System.IO;
+using AutoFixture;
+using AutoFixture.AutoMoq;
+using Emby.Naming.Common;
+using Emby.Server.Implementations.IO;
+using Emby.Server.Implementations.Library;
+using MediaBrowser.Controller;
+using MediaBrowser.Controller.Configuration;
+using MediaBrowser.Controller.Sorting;
+using MediaBrowser.Model.IO;
+using Microsoft.Extensions.Logging.Abstractions;
+using Moq;
+using Xunit;
+
+namespace Jellyfin.Server.Implementations.Tests.Library.LibraryManager;
+
+public sealed class LibraryRootIgnoreTests : IDisposable
+{
+ private readonly string _tempDir;
+ private readonly string _userViewsPath;
+ private readonly string _libraryRoot;
+ private readonly FileSystemMetadata _movieFile;
+
+ public LibraryRootIgnoreTests()
+ {
+ _tempDir = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString());
+ _userViewsPath = Path.Combine(_tempDir, "root", "default");
+ _libraryRoot = Path.Combine(_tempDir, "media", "Movies");
+ var movieDir = Path.Combine(_libraryRoot, "Movie (2020)");
+ Directory.CreateDirectory(movieDir);
+
+ // Ignores everything below it, but sits above the library root
+ File.WriteAllText(Path.Combine(_tempDir, ".ignore"), string.Empty);
+
+ _movieFile = new FileSystemMetadata
+ {
+ FullName = Path.Combine(movieDir, "Movie (2020).mkv"),
+ IsDirectory = false
+ };
+ }
+
+ public void Dispose()
+ {
+ Directory.Delete(_tempDir, true);
+ }
+
+ [Fact]
+ public void IgnoreFile_IgnoreFileAboveMblinkLibraryRoot_IsNotConsulted()
+ {
+ var libraryDir = Path.Combine(_userViewsPath, "Movies");
+ Directory.CreateDirectory(libraryDir);
+ File.WriteAllText(Path.Combine(libraryDir, "Movies.mblink"), _libraryRoot);
+
+ Assert.False(CreateLibraryManager().IgnoreFile(_movieFile, null));
+ }
+
+ [Fact]
+ public void IgnoreFile_UserViewsPathMissing_WalksToFilesystemRoot()
+ {
+ // Before root/default exists there are no library roots, so the .ignore above still applies
+ Assert.False(Directory.Exists(_userViewsPath));
+ Assert.True(CreateLibraryManager().IgnoreFile(_movieFile, null));
+ }
+
+ private Emby.Server.Implementations.Library.LibraryManager CreateLibraryManager()
+ {
+ var fixture = new Fixture().Customize(new AutoMoqCustomization());
+ fixture.Register(() => new NamingOptions());
+ var configMock = fixture.Freeze<Mock<IServerConfigurationManager>>();
+ configMock.Setup(c => c.ApplicationPaths.ProgramDataPath).Returns(_tempDir);
+ configMock.Setup(c => c.ApplicationPaths.DefaultUserViewsPath).Returns(_userViewsPath);
+ fixture.Freeze<Mock<IServerApplicationHost>>()
+ .Setup(h => h.ExpandVirtualPath(It.IsAny<string>()))
+ .Returns<string>(path => path);
+ fixture.Inject<IFileSystem>(new ManagedFileSystem(
+ NullLogger<ManagedFileSystem>.Instance,
+ configMock.Object.ApplicationPaths,
+ [new MbLinkShortcutHandler()]));
+
+ // The same instance LibraryManager hands the roots to must be the one evaluating the rules
+ var dotIgnoreRule = new DotIgnoreIgnoreRule();
+ fixture.Inject(dotIgnoreRule);
+
+ return fixture.Build<Emby.Server.Implementations.Library.LibraryManager>().Do(s => s.AddParts(
+ [dotIgnoreRule],
+ [],
+ [],
+ Array.Empty<IBaseItemComparer>(),
+ []))
+ .Create();
+ }
+}
diff --git a/tests/Jellyfin.Server.Integration.Tests/DotIgnoreLibraryRootTests.cs b/tests/Jellyfin.Server.Integration.Tests/DotIgnoreLibraryRootTests.cs
new file mode 100644
index 0000000000..2fd598e6b2
--- /dev/null
+++ b/tests/Jellyfin.Server.Integration.Tests/DotIgnoreLibraryRootTests.cs
@@ -0,0 +1,55 @@
+using System;
+using System.IO;
+using Emby.Server.Implementations.Library;
+using MediaBrowser.Controller;
+using MediaBrowser.Controller.Entities;
+using MediaBrowser.Controller.Library;
+using MediaBrowser.Model.IO;
+using Microsoft.Extensions.DependencyInjection;
+using Xunit;
+
+namespace Jellyfin.Server.Integration.Tests;
+
+public sealed class DotIgnoreLibraryRootTests : IClassFixture<JellyfinApplicationFactory>
+{
+ private readonly JellyfinApplicationFactory _factory;
+
+ public DotIgnoreLibraryRootTests(JellyfinApplicationFactory factory)
+ {
+ _factory = factory;
+ }
+
+ [Fact]
+ public void IgnoreFile_IgnoreFileAboveLibraryRoot_IsNotConsulted()
+ {
+ _ = _factory.CreateClient();
+
+ var tempDir = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString());
+ var libraryRoot = Path.Combine(tempDir, "Movies");
+ var movieDir = Path.Combine(libraryRoot, "Movie (2020)");
+ Directory.CreateDirectory(movieDir);
+ var libraryDir = Path.Combine(_factory.Services.GetRequiredService<IServerApplicationPaths>().DefaultUserViewsPath, "dotignore-root-test");
+ Directory.CreateDirectory(libraryDir);
+
+ try
+ {
+ File.WriteAllText(Path.Combine(tempDir, ".ignore"), string.Empty);
+ File.WriteAllText(Path.Combine(libraryDir, "Movies.mblink"), libraryRoot);
+
+ // The rule the resolver evaluates must be the singleton LibraryManager hands the roots to
+ _factory.Services.GetRequiredService<DotIgnoreIgnoreRule>().ClearDirectoryCache();
+ var fileInfo = new FileSystemMetadata
+ {
+ FullName = Path.Combine(movieDir, "Movie (2020).mkv"),
+ IsDirectory = false
+ };
+
+ Assert.False(_factory.Services.GetRequiredService<ILibraryManager>().IgnoreFile(fileInfo, new Folder { Path = movieDir }));
+ }
+ finally
+ {
+ Directory.Delete(libraryDir, true);
+ Directory.Delete(tempDir, true);
+ }
+ }
+}