Skip corrupt KeyframeData rows during full system backup

A single row with malformed KeyframeTicks JSON (e.g. a truncated array
from an interrupted write) currently aborts the entire backup, because
the try/catch in BackupService.CreateBackupAsync only wraps
serialization of an already-materialized entity, not the enumeration
itself. EF Core throws JsonReaderException from MoveNextAsync() while
materializing the corrupt row, which propagates past that catch block.

Switch to manual enumerator iteration so MoveNextAsync() failures can
be caught per-row, logged as a warning identifying the affected table,
and skipped, allowing the remaining rows and the rest of the backup to
complete.

Fixes #17216

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

1 files changed, 178 insertions, 0 deletions

diff --git a/tests/Jellyfin.Server.Implementations.Tests/FullSystemBackup/BackupServiceTests.cs b/tests/Jellyfin.Server.Implementations.Tests/FullSystemBackup/BackupServiceTests.cs
new file mode 100644
index 0000000000..e868b8c9a5
--- /dev/null
+++ b/tests/Jellyfin.Server.Implementations.Tests/FullSystemBackup/BackupServiceTests.cs
@@ -0,0 +1,178 @@
+using System;
+using System.IO;
+using System.IO.Compression;
+using System.Linq;
+using System.Text.Json;
+using System.Threading;
+using System.Threading.Tasks;
+using Jellyfin.Database.Implementations;
+using Jellyfin.Database.Implementations.Entities;
+using Jellyfin.Database.Implementations.Locking;
+using Jellyfin.Database.Providers.Sqlite;
+using Jellyfin.Server.Implementations.FullSystemBackup;
+using MediaBrowser.Controller;
+using MediaBrowser.Controller.Library;
+using MediaBrowser.Controller.SystemBackupService;
+using Microsoft.Data.Sqlite;
+using Microsoft.EntityFrameworkCore;
+using Microsoft.Extensions.Hosting;
+using Microsoft.Extensions.Logging.Abstractions;
+using Moq;
+using Xunit;
+using BaseItemKind = Jellyfin.Data.Enums.BaseItemKind;
+
+namespace Jellyfin.Server.Implementations.Tests.FullSystemBackup;
+
+/// <summary>
+/// Tests for <see cref="BackupService"/>, in particular that a single row of corrupt
+/// <see cref="KeyframeData"/> (e.g. malformed <c>KeyframeTicks</c> JSON) does not abort
+/// an otherwise healthy backup. See https://github.com/jellyfin/jellyfin/issues/17216.
+/// </summary>
+public sealed class BackupServiceTests : IDisposable
+{
+    private readonly SqliteConnection _connection;
+    private readonly DbContextOptions<JellyfinDbContext> _dbOptions;
+    private readonly string _testRoot;
+    private readonly string _backupPath;
+    private readonly string _configurationDirectoryPath;
+
+    public BackupServiceTests()
+    {
+        _connection = new SqliteConnection("Data Source=:memory:");
+        _connection.Open();
+
+        _dbOptions = new DbContextOptionsBuilder<JellyfinDbContext>()
+            .UseSqlite(_connection)
+            .Options;
+
+        using (var ctx = CreateDbContext())
+        {
+            ctx.Database.EnsureCreated();
+        }
+
+        _testRoot = Path.Combine(Path.GetTempPath(), "jellyfin-backup-service-tests-" + Guid.NewGuid().ToString("N"));
+        _backupPath = Path.Combine(_testRoot, "Backup");
+        _configurationDirectoryPath = Path.Combine(_testRoot, "Config");
+        Directory.CreateDirectory(_backupPath);
+        Directory.CreateDirectory(_configurationDirectoryPath);
+    }
+
+    public void Dispose()
+    {
+        _connection.Dispose();
+
+        if (Directory.Exists(_testRoot))
+        {
+            Directory.Delete(_testRoot, true);
+        }
+    }
+
+    [Fact]
+    public async Task CreateBackupAsync_WithCorruptKeyframeDataRow_SkipsRowAndCompletesBackup()
+    {
+        var cancellationToken = TestContext.Current.CancellationToken;
+        var validItemId = Guid.Parse("11111111-1111-1111-1111-111111111111");
+        var corruptItemId = Guid.Parse("22222222-2222-2222-2222-222222222222");
+
+        await using (var ctx = CreateDbContext())
+        {
+            // A healthy item + keyframe row, written the normal way.
+            ctx.BaseItems.Add(CreateMovieEntity(validItemId, "Good Movie"));
+            ctx.BaseItems.Add(CreateMovieEntity(corruptItemId, "Corrupt Movie"));
+            await ctx.SaveChangesAsync(cancellationToken).ConfigureAwait(true);
+
+            ctx.KeyframeData.Add(new KeyframeData
+            {
+                ItemId = validItemId,
+                TotalDuration = 60_000,
+                KeyframeTicks = [0, 1000, 2000]
+            });
+            await ctx.SaveChangesAsync(cancellationToken).ConfigureAwait(true);
+
+            // Simulate a corrupted database row: truncated JSON array for KeyframeTicks,
+            // written directly via SQL to bypass EF's normal (well-formed) write path.
+            await ctx.Database.ExecuteSqlInterpolatedAsync(
+                $"INSERT INTO KeyframeData (ItemId, TotalDuration, KeyframeTicks) VALUES ({corruptItemId.ToString()}, {5000L}, {"[1,2,3"})",
+                cancellationToken).ConfigureAwait(true);
+        }
+
+        var backupService = CreateBackupService();
+
+        var manifest = await backupService.CreateBackupAsync(new BackupOptionsDto()).ConfigureAwait(true);
+
+        Assert.True(File.Exists(manifest.Path));
+
+        using var archive = await ZipFile.OpenReadAsync(manifest.Path, cancellationToken).ConfigureAwait(true);
+        var keyframeEntry = archive.GetEntry("Database/KeyframeData.json");
+        Assert.NotNull(keyframeEntry);
+
+        await using var entryStream = await keyframeEntry!.OpenAsync(cancellationToken).ConfigureAwait(true);
+        using var document = await JsonDocument.ParseAsync(entryStream, cancellationToken: cancellationToken).ConfigureAwait(true);
+
+        var rows = document.RootElement.EnumerateArray().ToList();
+
+        // The corrupt row must be skipped, but the valid row must still make it into the backup.
+        var singleRow = Assert.Single(rows);
+        Assert.Equal(validItemId, singleRow.GetProperty("ItemId").GetGuid());
+    }
+
+    private BackupService CreateBackupService()
+    {
+        var factory = new Mock<IDbContextFactory<JellyfinDbContext>>();
+        factory.Setup(f => f.CreateDbContext()).Returns(CreateDbContext);
+        factory.Setup(f => f.CreateDbContextAsync(It.IsAny<CancellationToken>())).ReturnsAsync(CreateDbContext);
+
+        var applicationHost = new Mock<IServerApplicationHost>();
+        applicationHost.Setup(a => a.ApplicationVersion).Returns(new Version(10, 11, 0));
+
+        var applicationPaths = new Mock<IServerApplicationPaths>();
+        applicationPaths.Setup(a => a.BackupPath).Returns(_backupPath);
+        applicationPaths.Setup(a => a.ConfigurationDirectoryPath).Returns(_configurationDirectoryPath);
+        applicationPaths.Setup(a => a.DataPath).Returns(Path.Combine(_testRoot, "Data"));
+        applicationPaths.Setup(a => a.RootFolderPath).Returns(Path.Combine(_testRoot, "Root"));
+        applicationPaths.Setup(a => a.InternalMetadataPath).Returns(Path.Combine(_testRoot, "Metadata"));
+        applicationPaths.Setup(a => a.DefaultInternalMetadataPath).Returns(Path.Combine(_testRoot, "MetadataDefault"));
+
+        var jellyfinDatabaseProvider = new Mock<IJellyfinDatabaseProvider>();
+        jellyfinDatabaseProvider.Setup(p => p.RunScheduledOptimisation(It.IsAny<CancellationToken>())).Returns(Task.CompletedTask);
+        jellyfinDatabaseProvider.Setup(p => p.PurgeDatabase(It.IsAny<JellyfinDbContext>(), It.IsAny<System.Collections.Generic.IEnumerable<string>>())).Returns(Task.CompletedTask);
+
+        var applicationLifetime = new Mock<IHostApplicationLifetime>();
+
+        var libraryManager = new Mock<ILibraryManager>();
+        libraryManager.Setup(l => l.IsScanRunning).Returns(false);
+
+        return new BackupService(
+            NullLogger<BackupService>.Instance,
+            factory.Object,
+            applicationHost.Object,
+            applicationPaths.Object,
+            jellyfinDatabaseProvider.Object,
+            applicationLifetime.Object,
+            libraryManager.Object);
+    }
+
+    private static BaseItemEntity CreateMovieEntity(Guid id, string name)
+    {
+        return new BaseItemEntity
+        {
+            Id = id,
+            Type = "Movie",
+            Name = name,
+            PresentationUniqueKey = id.ToString("N"),
+            MediaType = "Video",
+            IsMovie = true,
+            IsFolder = false,
+            IsVirtualItem = false
+        };
+    }
+
+    private JellyfinDbContext CreateDbContext()
+    {
+        return new JellyfinDbContext(
+            _dbOptions,
+            NullLogger<JellyfinDbContext>.Instance,
+            new SqliteDatabaseProvider(null!, NullLogger<SqliteDatabaseProvider>.Instance),
+            new NoLockBehavior(NullLogger<NoLockBehavior>.Instance));
+    }
+}