sync fixes

4 files changed, 24 insertions, 21 deletions

diff --git a/MediaBrowser.Providers/BoxSets/BoxSetMetadataService.cs b/MediaBrowser.Providers/BoxSets/BoxSetMetadataService.cs
index 062519f9d5..5afaaa8753 100644
--- a/MediaBrowser.Providers/BoxSets/BoxSetMetadataService.cs
+++ b/MediaBrowser.Providers/BoxSets/BoxSetMetadataService.cs
@@ -75,7 +75,7 @@ namespace MediaBrowser.Providers.BoxSets
                 if (!string.Equals(currentOfficialRating ?? string.Empty, item.OfficialRating ?? string.Empty,
                     StringComparison.OrdinalIgnoreCase))
                 {
-                    updateType = updateType | ItemUpdateType.MetadataDownload;
+                    updateType = updateType | ItemUpdateType.MetadataEdit;
                 }
             }
 
diff --git a/MediaBrowser.Providers/Music/AlbumMetadataService.cs b/MediaBrowser.Providers/Music/AlbumMetadataService.cs
index 79fab2f704..6e3a5bf063 100644
--- a/MediaBrowser.Providers/Music/AlbumMetadataService.cs
+++ b/MediaBrowser.Providers/Music/AlbumMetadataService.cs
@@ -54,7 +54,7 @@ namespace MediaBrowser.Providers.Music
 
                     if (currentList.Count != item.Genres.Count || !currentList.OrderBy(i => i).SequenceEqual(item.Genres.OrderBy(i => i), StringComparer.OrdinalIgnoreCase))
                     {
-                        updateType = updateType | ItemUpdateType.MetadataDownload;
+                        updateType = updateType | ItemUpdateType.MetadataEdit;
                     }
                 }
 
@@ -68,7 +68,7 @@ namespace MediaBrowser.Providers.Music
 
                     if (currentList.Count != item.Studios.Count || !currentList.OrderBy(i => i).SequenceEqual(item.Studios.OrderBy(i => i), StringComparer.OrdinalIgnoreCase))
                     {
-                        updateType = updateType | ItemUpdateType.MetadataDownload;
+                        updateType = updateType | ItemUpdateType.MetadataEdit;
                     }
                 }
 
@@ -81,15 +81,15 @@ namespace MediaBrowser.Providers.Music
                         if (!string.Equals(item.Name, name, StringComparison.Ordinal))
                         {
                             item.Name = name;
-                            updateType = updateType | ItemUpdateType.MetadataDownload;
+                            updateType = updateType | ItemUpdateType.MetadataEdit;
                         }
                     }
                 }
-            }
 
-            updateType = updateType | SetAlbumArtistFromSongs(item, songs);
-            updateType = updateType | SetArtistsFromSongs(item, songs);
-            updateType = updateType | SetDateFromSongs(item, songs);
+                updateType = updateType | SetAlbumArtistFromSongs(item, songs);
+                updateType = updateType | SetArtistsFromSongs(item, songs);
+                updateType = updateType | SetDateFromSongs(item, songs);
+            }
 
             return updateType;
         }
@@ -106,7 +106,7 @@ namespace MediaBrowser.Providers.Music
             if (!item.AlbumArtists.SequenceEqual(albumArtists, StringComparer.OrdinalIgnoreCase))
             {
                 item.AlbumArtists = albumArtists;
-                updateType = updateType | ItemUpdateType.MetadataDownload;
+                updateType = updateType | ItemUpdateType.MetadataEdit;
             }
 
             return updateType;
@@ -124,7 +124,7 @@ namespace MediaBrowser.Providers.Music
 
             if (currentList.Count != item.Artists.Count || !currentList.OrderBy(i => i).SequenceEqual(item.Artists.OrderBy(i => i), StringComparer.OrdinalIgnoreCase))
             {
-                updateType = updateType | ItemUpdateType.MetadataDownload;
+                updateType = updateType | ItemUpdateType.MetadataEdit;
             }
 
             return updateType;
@@ -158,7 +158,7 @@ namespace MediaBrowser.Providers.Music
             if ((originalPremiereDate ?? DateTime.MinValue) != (item.PremiereDate ?? DateTime.MinValue) ||
                 (originalProductionYear ?? -1) != (item.ProductionYear ?? -1))
             {
-                updateType = updateType | ItemUpdateType.MetadataDownload;
+                updateType = updateType | ItemUpdateType.MetadataEdit;
             }
 
             return updateType;
diff --git a/MediaBrowser.Providers/Music/ArtistMetadataService.cs b/MediaBrowser.Providers/Music/ArtistMetadataService.cs
index 939bd2b3be..a73d82992d 100644
--- a/MediaBrowser.Providers/Music/ArtistMetadataService.cs
+++ b/MediaBrowser.Providers/Music/ArtistMetadataService.cs
@@ -35,19 +35,22 @@ namespace MediaBrowser.Providers.Music
         {
             var updateType = base.BeforeSave(item);
 
-            if (!item.IsAccessedByName && !item.LockedFields.Contains(MetadataFields.Genres))
+            if (!item.IsAccessedByName && !item.IsLocked)
             {
-                var songs = item.RecursiveChildren.OfType<Audio>().ToList();
+                if (!item.LockedFields.Contains(MetadataFields.Genres))
+                {
+                    var songs = item.RecursiveChildren.OfType<Audio>().ToList();
 
-                var currentList = item.Genres.ToList();
+                    var currentList = item.Genres.ToList();
 
-                item.Genres = songs.SelectMany(i => i.Genres)
-                    .Distinct(StringComparer.OrdinalIgnoreCase)
-                    .ToList();
+                    item.Genres = songs.SelectMany(i => i.Genres)
+                        .Distinct(StringComparer.OrdinalIgnoreCase)
+                        .ToList();
 
-                if (currentList.Count != item.Genres.Count || !currentList.OrderBy(i => i).SequenceEqual(item.Genres.OrderBy(i => i), StringComparer.OrdinalIgnoreCase))
-                {
-                    updateType = updateType | ItemUpdateType.MetadataDownload;
+                    if (currentList.Count != item.Genres.Count || !currentList.OrderBy(i => i).SequenceEqual(item.Genres.OrderBy(i => i), StringComparer.OrdinalIgnoreCase))
+                    {
+                        updateType = updateType | ItemUpdateType.MetadataEdit;
+                    }
                 }
             } 
             
diff --git a/MediaBrowser.Providers/TV/TvdbSeriesProvider.cs b/MediaBrowser.Providers/TV/TvdbSeriesProvider.cs
index 69f1123d02..20dc6c4859 100644
--- a/MediaBrowser.Providers/TV/TvdbSeriesProvider.cs
+++ b/MediaBrowser.Providers/TV/TvdbSeriesProvider.cs
@@ -210,7 +210,7 @@ namespace MediaBrowser.Providers.TV
                     await zipStream.CopyToAsync(ms).ConfigureAwait(false);
 
                     ms.Position = 0;
-                    _zipClient.ExtractAll(ms, seriesDataPath, true);
+                    _zipClient.ExtractAllFromZip(ms, seriesDataPath, true);
                 }
             }