diff options
| author | brandon <brandon@clinger.dev> | 2026-08-08 12:33:11 -0400 |
|---|---|---|
| committer | brandon <brandon@clinger.dev> | 2026-08-08 12:33:11 -0400 |
| commit | 10d108a1f453c0972b3059e10bb9b13bbcb34f63 (patch) | |
| tree | b00f02ff96a21a78b35ca69ef5614466e0afc3ca /MediaBrowser.Controller | |
| parent | c091ffdc6b2d8d4dd6f439d056c561bae7bd9a18 (diff) | |
Address review on MediaSourceCount batching
Rename GetItemsWithAlternateVersions to GetItemIdsWithAlternateVersions
across the interfaces and implementations since it returns ids. Return
the hashset straight from the query instead of materializing an array
first. Rename the DtoService guard to mayHaveAlternateVersions and
invert it so the computed path is the explicit case. Assert the media
source count value in the batch skip test and add a test covering an
item that is in the returned set still resolving to the correct count.
Diffstat (limited to 'MediaBrowser.Controller')
| -rw-r--r-- | MediaBrowser.Controller/Library/ILibraryManager.cs | 2 | ||||
| -rw-r--r-- | MediaBrowser.Controller/Persistence/ILinkedChildrenService.cs | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/MediaBrowser.Controller/Library/ILibraryManager.cs b/MediaBrowser.Controller/Library/ILibraryManager.cs index f6bd948b99..ca686fbd9d 100644 --- a/MediaBrowser.Controller/Library/ILibraryManager.cs +++ b/MediaBrowser.Controller/Library/ILibraryManager.cs @@ -261,7 +261,7 @@ namespace MediaBrowser.Controller.Library /// </summary> /// <param name="itemIds">The item IDs to check.</param> /// <returns>The set of item IDs that have alternate versions.</returns> - IReadOnlySet<Guid> GetItemsWithAlternateVersions(IReadOnlyList<Guid> itemIds); + IReadOnlySet<Guid> GetItemIdsWithAlternateVersions(IReadOnlyList<Guid> itemIds); /// <summary> /// Creates or updates a LinkedChild entry linking a parent to a child item. diff --git a/MediaBrowser.Controller/Persistence/ILinkedChildrenService.cs b/MediaBrowser.Controller/Persistence/ILinkedChildrenService.cs index c1fe3231f4..79c29410e4 100644 --- a/MediaBrowser.Controller/Persistence/ILinkedChildrenService.cs +++ b/MediaBrowser.Controller/Persistence/ILinkedChildrenService.cs @@ -26,7 +26,7 @@ public interface ILinkedChildrenService /// </summary> /// <param name="itemIds">The item IDs to check.</param> /// <returns>The set of item IDs that have alternate versions.</returns> - IReadOnlySet<Guid> GetItemsWithAlternateVersions(IReadOnlyList<Guid> itemIds); + IReadOnlySet<Guid> GetItemIdsWithAlternateVersions(IReadOnlyList<Guid> itemIds); /// <summary> /// Gets all artist matches from the database. |