Merge pull request #17579 from Shadowghost/fix-removal-notification

Fix missing ItemRemoved events and search fallback after access filtering

1 files changed, 9 insertions, 3 deletions

diff --git a/MediaBrowser.Controller/Library/SearchProviderQuery.cs b/MediaBrowser.Controller/Library/SearchProviderQuery.cs
index 845588c872..b1ff800fa0 100644
--- a/MediaBrowser.Controller/Library/SearchProviderQuery.cs
+++ b/MediaBrowser.Controller/Library/SearchProviderQuery.cs
@@ -19,7 +19,9 @@ public class SearchProviderQuery
     public Guid? UserId { get; init; }
 
     /// <summary>
-    /// Gets the item types to include in the search.
+    /// Gets the item types to include in the search. An empty array means every type is eligible.
+    /// When this is non-empty it is the authoritative type filter and <see cref="ExcludeItemTypes"/>
+    /// does not apply; excludes only take effect when no include types were requested.
     /// </summary>
     public BaseItemKind[] IncludeItemTypes { get; init; } = [];
 
@@ -29,7 +31,9 @@ public class SearchProviderQuery
     public BaseItemKind[] ExcludeItemTypes { get; init; } = [];
 
     /// <summary>
-    /// Gets the media types to include in the search.
+    /// Gets the media types to include in the search. This is an additional constraint rather than
+    /// an alternative one: a provider must return only items that match both the requested media
+    /// types and the requested item types, not the union of the two.
     /// </summary>
     public MediaType[] MediaTypes { get; init; } = [];
 
@@ -39,7 +43,9 @@ public class SearchProviderQuery
     public int? Limit { get; init; }
 
     /// <summary>
-    /// Gets the parent ID to scope the search.
+    /// Gets the parent ID to scope the search. This scopes to the whole subtree, not just direct
+    /// children - callers routinely pass a library folder id and expect items nested arbitrarily
+    /// deep beneath it (an episode under a season under a series) to match.
     /// </summary>
     public Guid? ParentId { get; init; }
 }