diff options
| author | Cosmin Dumitru <cosu@cosu.ro> | 2026-02-18 21:08:35 +0100 |
|---|---|---|
| committer | Cosmin Dumitru <cosu@cosu.ro> | 2026-02-18 21:08:35 +0100 |
| commit | 37b50fe13c689e8fb89288da12f79bf7164e1194 (patch) | |
| tree | 6700515145dc62c913dc7524b3392f396747dc1b /Emby.Server.Implementations/Localization/Core/ca.json | |
| parent | 06a6c6e16b274e99e00402a21818d4dbb760eca7 (diff) | |
Fix malformed query string in StreamInfo.ToUrl() causing 500 error via proxies
StreamInfo.ToUrl() generated URLs like `/master.m3u8?&DeviceId=...` (note `?&`)
because `?` was appended to the path and all parameters started with `&`. When
the first optional parameter (DeviceProfileId) was null, the result was a
malformed query string.
This is harmless when clients hit Jellyfin directly (ASP.NET Core tolerates `?&`),
but when accessed through a reverse proxy that parses and re-serializes the URL
(e.g. Home Assistant ingress via aiohttp/yarl), `?&` becomes `?=&` — introducing
an empty-key query parameter. ParseStreamOptions then crashes on `param.Key[0]`
with IndexOutOfRangeException.
Changes:
- StreamInfo.ToUrl(): Track query start position and replace the first `&` with
`?` after all parameters are appended, producing valid query strings
- ParseStreamOptions: Guard against empty query parameter keys
- Tests: Remove .Replace("?&", "?") workaround that masked the bug
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Diffstat (limited to 'Emby.Server.Implementations/Localization/Core/ca.json')
0 files changed, 0 insertions, 0 deletions