From 10d108a1f453c0972b3059e10bb9b13bbcb34f63 Mon Sep 17 00:00:00 2001 From: brandon Date: Sat, 8 Aug 2026 12:33:11 -0400 Subject: Address review on MediaSourceCount batching Rename GetItemsWithAlternateVersions to GetItemIdsWithAlternateVersions across the interfaces and implementations since it returns ids. Return the hashset straight from the query instead of materializing an array first. Rename the DtoService guard to mayHaveAlternateVersions and invert it so the computed path is the explicit case. Assert the media source count value in the batch skip test and add a test covering an item that is in the returned set still resolving to the correct count. --- MediaBrowser.Controller/Library/ILibraryManager.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'MediaBrowser.Controller/Library/ILibraryManager.cs') diff --git a/MediaBrowser.Controller/Library/ILibraryManager.cs b/MediaBrowser.Controller/Library/ILibraryManager.cs index f6bd948b99..ca686fbd9d 100644 --- a/MediaBrowser.Controller/Library/ILibraryManager.cs +++ b/MediaBrowser.Controller/Library/ILibraryManager.cs @@ -261,7 +261,7 @@ namespace MediaBrowser.Controller.Library /// /// The item IDs to check. /// The set of item IDs that have alternate versions. - IReadOnlySet GetItemsWithAlternateVersions(IReadOnlyList itemIds); + IReadOnlySet GetItemIdsWithAlternateVersions(IReadOnlyList itemIds); /// /// Creates or updates a LinkedChild entry linking a parent to a child item. -- cgit v1.2.3