aboutsummaryrefslogtreecommitdiff
path: root/tests/Jellyfin.MediaEncoding.Tests/Subtitles/SubtitleEncoderTests.cs
AgeCommit message (Collapse)Author
2026-07-21Fix subtitle encoding for local files (#17281)Tim Eisele
* Fix subtitle encoding * Add short-circuit * Use IsTextFormat * Update MediaBrowser.MediaEncoding/Subtitles/SubtitleEncoder.cs Co-authored-by: Bond-009 <bond.009@outlook.com> --------- Co-authored-by: Bond-009 <bond.009@outlook.com>
2026-07-15Fix race condition in concurrent subtitle conversionPiotr Niełacny
SubtitleEncoder.ConvertSubtitles parsed subtitles with libse's static Subtitle.Parse, which iterates a statically cached list of shared SubtitleFormat instances. Format parsers keep mutable per-parse state on the instance, so concurrent subtitle requests corrupted each other's output (cues mixed across streams and languages, truncated files) or failed with NullReferenceException when format detection broke down and Subtitle.Parse returned null. Parse through the injected ISubtitleParser instead. SubtitleEditParser instantiates a fresh format parser per call, so requests no longer share state. Its Parse method now returns the libse Subtitle directly (the SubtitleTrackInfo flattening was unused since the SubtitleEdit writer rework) so the writers keep full fidelity such as ASS styling.
2023-09-18Fix xUnit1030: Do not call ConfigureAwait in test methodBond_009
2023-01-11Fix all warnings in MediaBrowser.MediaEncoding (#9073)Bond-009
2022-09-09Fix build errors from new warningsCody Robibero
2021-10-03Fix warning: Using directive is not required by the code and can be safely ↵KonH
removed (#2149)
2021-09-18Add regression test for issue #5168Bond_009
2021-09-18Fix SubtitleEncoder and add regression testsBond_009